mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
253 stars 100 forks source link

adding location selected to struct #5960

Closed chelseybeck closed 2 months ago

chelseybeck commented 2 months ago

The CI is failing on dry run b/c this field is missing from the struct

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 2 months ago

Integration report for "adding location selected to struct"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/query.sql 2024-07-23 17:45:38.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/query.sql 2024-07-23 17:45:43.000000000 +0000 @@ -359,6 +359,7 @@ ARRAY_AGG( STRUCT( weather_widget_impressions, + weather_widget_location_selected, weather_widget_clicks, weather_widget_load_errors, weather_widget_change_display_to_detailed, ```

Link to full diff

dataops-ci-bot commented 2 months ago

Integration report for "Fix test error"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/query.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/query.sql 2024-07-23 18:31:27.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/newtab_visits_v1/query.sql 2024-07-23 18:31:23.000000000 +0000 @@ -359,6 +359,7 @@ ARRAY_AGG( STRUCT( weather_widget_impressions, + weather_widget_location_selected, weather_widget_clicks, weather_widget_load_errors, weather_widget_change_display_to_detailed, ```

Link to full diff