mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
253 stars 100 forks source link

fix(GLAM): Fix udf name #5961

Closed edugfilho closed 2 months ago

edugfilho commented 2 months ago

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 2 months ago

Integration report for "fix(GLAM): Fix udf name"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql 2024-07-23 19:01:20.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql 2024-07-23 19:01:26.000000000 +0000 @@ -6,13 +6,13 @@ IF( percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(histogram) + mozfun.glam.histogram_cast_struct(histogram) ) AS struct_histogram, IF( metric_type IN ("scalar", "keyed-scalar") OR non_norm_percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(non_norm_histogram) + mozfun.glam.histogram_cast_struct(non_norm_histogram) ) AS struct_non_norm_histogram, percentiles AS existing_percentiles, non_norm_percentiles AS existing_non_norm_percentiles diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql 2024-07-23 19:01:20.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql 2024-07-23 19:01:26.000000000 +0000 @@ -6,13 +6,13 @@ IF( percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(histogram) + mozfun.glam.histogram_cast_struct(histogram) ) AS struct_histogram, IF( metric_type IN ("scalar", "keyed-scalar") OR non_norm_percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(non_norm_histogram) + mozfun.glam.histogram_cast_struct(non_norm_histogram) ) AS struct_non_norm_histogram, percentiles AS existing_percentiles, non_norm_percentiles AS existing_non_norm_percentiles diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql 2024-07-23 19:01:20.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql 2024-07-23 19:01:26.000000000 +0000 @@ -6,13 +6,13 @@ IF( percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(histogram) + mozfun.glam.histogram_cast_struct(histogram) ) AS struct_histogram, IF( metric_type IN ("scalar", "keyed-scalar") OR non_norm_percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(non_norm_histogram) + mozfun.glam.histogram_cast_struct(non_norm_histogram) ) AS struct_non_norm_histogram, percentiles AS existing_percentiles, non_norm_percentiles AS existing_non_norm_percentiles diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql 2024-07-23 19:01:20.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql 2024-07-23 19:01:26.000000000 +0000 @@ -6,13 +6,13 @@ IF( percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(histogram) + mozfun.glam.histogram_cast_struct(histogram) ) AS struct_histogram, IF( metric_type IN ("counter", "labeled_counter", "quantity") OR non_norm_percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(non_norm_histogram) + mozfun.glam.histogram_cast_struct(non_norm_histogram) ) AS struct_non_norm_histogram, percentiles AS existing_percentiles, non_norm_percentiles AS existing_non_norm_percentiles diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql 2024-07-23 19:01:20.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql 2024-07-23 19:01:26.000000000 +0000 @@ -6,13 +6,13 @@ IF( percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(histogram) + mozfun.glam.histogram_cast_struct(histogram) ) AS struct_histogram, IF( metric_type IN ("counter", "labeled_counter", "quantity") OR non_norm_percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(non_norm_histogram) + mozfun.glam.histogram_cast_struct(non_norm_histogram) ) AS struct_non_norm_histogram, percentiles AS existing_percentiles, non_norm_percentiles AS existing_non_norm_percentiles diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql 2024-07-23 19:01:20.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql 2024-07-23 19:01:26.000000000 +0000 @@ -6,13 +6,13 @@ IF( percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(histogram) + mozfun.glam.histogram_cast_struct(histogram) ) AS struct_histogram, IF( metric_type IN ("counter", "labeled_counter", "quantity") OR non_norm_percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(non_norm_histogram) + mozfun.glam.histogram_cast_struct(non_norm_histogram) ) AS struct_non_norm_histogram, percentiles AS existing_percentiles, non_norm_percentiles AS existing_non_norm_percentiles diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql 2024-07-23 19:01:20.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql 2024-07-23 19:01:26.000000000 +0000 @@ -6,13 +6,13 @@ IF( percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(histogram) + mozfun.glam.histogram_cast_struct(histogram) ) AS struct_histogram, IF( metric_type IN ("counter", "labeled_counter", "quantity") OR non_norm_percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(non_norm_histogram) + mozfun.glam.histogram_cast_struct(non_norm_histogram) ) AS struct_non_norm_histogram, percentiles AS existing_percentiles, non_norm_percentiles AS existing_non_norm_percentiles diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql 2024-07-23 19:01:20.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql 2024-07-23 19:01:26.000000000 +0000 @@ -6,13 +6,13 @@ IF( percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(histogram) + mozfun.glam.histogram_cast_struct(histogram) ) AS struct_histogram, IF( metric_type IN ("counter", "labeled_counter", "quantity") OR non_norm_percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(non_norm_histogram) + mozfun.glam.histogram_cast_struct(non_norm_histogram) ) AS struct_non_norm_histogram, percentiles AS existing_percentiles, non_norm_percentiles AS existing_non_norm_percentiles diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql 2024-07-23 19:01:20.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql 2024-07-23 19:01:26.000000000 +0000 @@ -6,13 +6,13 @@ IF( percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(histogram) + mozfun.glam.histogram_cast_struct(histogram) ) AS struct_histogram, IF( metric_type IN ("counter", "labeled_counter", "quantity") OR non_norm_percentiles IS NOT NULL, NULL, - udfs.glam_histogram_to_struct(non_norm_histogram) + mozfun.glam.histogram_cast_struct(non_norm_histogram) ) AS struct_non_norm_histogram, percentiles AS existing_percentiles, non_norm_percentiles AS existing_non_norm_percentiles ```

Link to full diff