Closed kik-kik closed 2 months ago
sql.diff
⚠️ Only part of the diff is displayed.
I think this is from the previous PR, but there was a UNIONed view for attribution_clients and I noticed two things in it:
is_suspicious_device_client
but I don't see that in the source tables you created nowsql.diff
⚠️ Only part of the diff is displayed.
I think this is from the previous PR, but there was a UNIONed view for attribution_clients and I noticed two things in it:
1. it was accounting for `is_suspicious_device_client` but I don't see that in the source tables you created now 2. Query looked a bit weird first with SELECT * EXCEPT and then placing the fields back 3. The fields changed to STRUCT but you are still querying with the old format
So regarding 1. this indeed appears to be missing in the generated attribution table. I will take a look tomorrow and get this resolved.
I see. No problem with the current EXCEPT/SELECT and with the STRUCT flattened out.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
sql.diff
⚠️ Only part of the diff is displayed.
feat(): add attribution_clients template to mobile_kpi_support_metrics sql generator
Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show up in the logs of themanual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):┆Issue is synchronized with this Jira Task