mozilla / bigquery-etl

Bigquery ETL
https://mozilla.github.io/bigquery-etl
Mozilla Public License 2.0
253 stars 100 forks source link

Don't fetch boolean probes since GLAM doesn't support them yet #5981

Closed edugfilho closed 2 months ago

edugfilho commented 2 months ago

This PR filters out boolean probes and Metrics from the GLAM views used to serve the app. GLAM does not officially support boolean probes yet.

Checklist for reviewer:

For modifications to schemas in restricted namespaces (see CODEOWNERS):

┆Issue is synchronized with this Jira Task

dataops-ci-bot commented 2 months ago

Integration report for "Don't fetch boolean probes since GLAM doesn't support them yet"

sql.diff

Click to expand! ```diff diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000 @@ -28,6 +28,7 @@ AND metric NOT LIKE r"%manager\_message\_size%" AND metric NOT LIKE r"%dropped\_frames\_proportion%" ) + AND metric_type NOT IN ("boolean", "keyed-scalar-boolean") ), calculated_percentiles AS ( SELECT diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000 @@ -28,6 +28,7 @@ AND metric NOT LIKE r"%manager\_message\_size%" AND metric NOT LIKE r"%dropped\_frames\_proportion%" ) + AND metric_type NOT IN ("boolean", "keyed-scalar-boolean") ), calculated_percentiles AS ( SELECT diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000 @@ -28,6 +28,7 @@ AND metric NOT LIKE r"%manager\_message\_size%" AND metric NOT LIKE r"%dropped\_frames\_proportion%" ) + AND metric_type NOT IN ("boolean", "keyed-scalar-boolean") ), calculated_percentiles AS ( SELECT diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000 @@ -28,6 +28,7 @@ AND metric NOT LIKE r"%manager\_message\_size%" AND metric NOT LIKE r"%dropped\_frames\_proportion%" ) + AND metric_type != "boolean" ), calculated_percentiles AS ( SELECT diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000 @@ -28,6 +28,7 @@ AND metric NOT LIKE r"%manager\_message\_size%" AND metric NOT LIKE r"%dropped\_frames\_proportion%" ) + AND metric_type != "boolean" ), calculated_percentiles AS ( SELECT diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000 @@ -28,6 +28,7 @@ AND metric NOT LIKE r"%manager\_message\_size%" AND metric NOT LIKE r"%dropped\_frames\_proportion%" ) + AND metric_type != "boolean" ), calculated_percentiles AS ( SELECT diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000 @@ -28,6 +28,7 @@ AND metric NOT LIKE r"%manager\_message\_size%" AND metric NOT LIKE r"%dropped\_frames\_proportion%" ) + AND metric_type != "boolean" ), calculated_percentiles AS ( SELECT diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000 @@ -28,6 +28,7 @@ AND metric NOT LIKE r"%manager\_message\_size%" AND metric NOT LIKE r"%dropped\_frames\_proportion%" ) + AND metric_type != "boolean" ), calculated_percentiles AS ( SELECT diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql --- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000 +++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000 @@ -28,6 +28,7 @@ AND metric NOT LIKE r"%manager\_message\_size%" AND metric NOT LIKE r"%dropped\_frames\_proportion%" ) + AND metric_type != "boolean" ), calculated_percentiles AS ( SELECT ```

Link to full diff