This PR filters out boolean probes and Metrics from the GLAM views used to serve the app. GLAM does not officially support boolean probes yet.
Checklist for reviewer:
[ ] Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title).
[ ] If the PR comes from a fork, trigger integration CI tests by running the Push to upstream workflow and provide the <username>:<branch> of the fork as parameter. The parameter will also show up
in the logs of the manual-trigger-required-for-fork CI task together with more detailed instructions.
[ ] If adding a new field to a query, ensure that the schema and dependent downstream schemas have been updated.
[ ] When adding a new derived dataset, ensure that data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data can be available in the bigquery-etl repository, looker-hub or in looker-spoke-default.
For modifications to schemas in restricted namespaces (see CODEOWNERS):
Integration report for "Don't fetch boolean probes since GLAM doesn't support them yet"
sql.diff
Click to expand!
```diff
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_beta_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000
@@ -28,6 +28,7 @@
AND metric NOT LIKE r"%manager\_message\_size%"
AND metric NOT LIKE r"%dropped\_frames\_proportion%"
)
+ AND metric_type NOT IN ("boolean", "keyed-scalar-boolean")
),
calculated_percentiles AS (
SELECT
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_nightly_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000
@@ -28,6 +28,7 @@
AND metric NOT LIKE r"%manager\_message\_size%"
AND metric NOT LIKE r"%dropped\_frames\_proportion%"
)
+ AND metric_type NOT IN ("boolean", "keyed-scalar-boolean")
),
calculated_percentiles AS (
SELECT
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_desktop_release_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000
@@ -28,6 +28,7 @@
AND metric NOT LIKE r"%manager\_message\_size%"
AND metric NOT LIKE r"%dropped\_frames\_proportion%"
)
+ AND metric_type NOT IN ("boolean", "keyed-scalar-boolean")
),
calculated_percentiles AS (
SELECT
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_beta_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000
@@ -28,6 +28,7 @@
AND metric NOT LIKE r"%manager\_message\_size%"
AND metric NOT LIKE r"%dropped\_frames\_proportion%"
)
+ AND metric_type != "boolean"
),
calculated_percentiles AS (
SELECT
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_nightly_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000
@@ -28,6 +28,7 @@
AND metric NOT LIKE r"%manager\_message\_size%"
AND metric NOT LIKE r"%dropped\_frames\_proportion%"
)
+ AND metric_type != "boolean"
),
calculated_percentiles AS (
SELECT
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fenix_release_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000
@@ -28,6 +28,7 @@
AND metric NOT LIKE r"%manager\_message\_size%"
AND metric NOT LIKE r"%dropped\_frames\_proportion%"
)
+ AND metric_type != "boolean"
),
calculated_percentiles AS (
SELECT
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_beta_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000
@@ -28,6 +28,7 @@
AND metric NOT LIKE r"%manager\_message\_size%"
AND metric NOT LIKE r"%dropped\_frames\_proportion%"
)
+ AND metric_type != "boolean"
),
calculated_percentiles AS (
SELECT
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_nightly_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000
@@ -28,6 +28,7 @@
AND metric NOT LIKE r"%manager\_message\_size%"
AND metric NOT LIKE r"%dropped\_frames\_proportion%"
)
+ AND metric_type != "boolean"
),
calculated_percentiles AS (
SELECT
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql 2024-07-26 18:34:36.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-glam-prod-fca7/glam_etl/glam_fog_release_aggregates/view.sql 2024-07-26 18:34:43.000000000 +0000
@@ -28,6 +28,7 @@
AND metric NOT LIKE r"%manager\_message\_size%"
AND metric NOT LIKE r"%dropped\_frames\_proportion%"
)
+ AND metric_type != "boolean"
),
calculated_percentiles AS (
SELECT
```
This PR filters out
boolean
probes and Metrics from the GLAM views used to serve the app. GLAM does not officially supportboolean
probes yet.Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show up in the logs of themanual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):┆Issue is synchronized with this Jira Task