search

mozilla / blogdotmozilladotorg

Project to manage work requests for blog.mozilla.org (Wordpress/WP engine, etc.)
Mozilla Public License 2.0
1 stars 1 forks source link

Bug 1534636 Implement better Download button for Firefox Nightly Blog #11

Open ejregithub opened 5 years ago

ejregithub commented 5 years ago

@ejregithub commented on Thu Mar 14 2019

Description

Bug 1534636 Implement better Download button for Firefox Nightly Blog

Steps to reproduce

Clear steps describing how to reproduce the issue. Providing a URL, screenshot.

Expected result

What should happen?

Actual result

What happened.

Environment

What browser and operating system are you using?

@alexgibson commented on Tue Apr 09 2019

This isn't related to www, so we should probably move this issue to https://github.com/mozilla/blogdotmozilladotorg/ (I tried to transfer but don't have perms for that repo).

ejregithub commented 5 years ago

Done, moved @alexgibson - I also added you as an admin to https://github.com/mozilla/blogdotmozilladotorg/

craigcook commented 5 years ago

This is a problem of too much text in too little space. The text wrapping can't be prevented, but I can at least try to make the bar expand to accommodate it. However, the button is a positioned element currently (hence the overflow)... I might have to resort to a secondary duplicate button that would appear inline just for mobile.

I would like to suggest just hiding the button on mobile and letting it appear in the hamburger menu so we don't have to mess with complicated positioning or duplicate buttons. That means the button will be less prominent in the UI, but how many clicks does it get on mobile anyway? Is it essential to have a download button visible in the mobile view of this sticky navbar? Who should we consult for this decision?