mozilla / blogdotmozilladotorg

Project to manage work requests for blog.mozilla.org (Wordpress/WP engine, etc.)
Mozilla Public License 2.0
1 stars 1 forks source link

Title contrast issues on berlin blog theme #3

Closed alexgibson closed 5 years ago

alexgibson commented 5 years ago

I noticed a few different posts on the Mozilla Berlin blog have colour contrast issues, due to the white heading in the top hero section being positioned over the top of hero images.

URLs & screenshots below:

https://blog.mozilla.org/berlin/die-heisseste-waehrung-im-internet-deine-aufmerksamkeit/

screenshot_2019-02-12 aufmerksamkeitsokonomie warum abkenkung ein milliardengeschaft ist - mozilla

https://blog.mozilla.org/berlin/wie-das-internet-beziehungen-neu-erfunden-hat-%e2%9d%a4%ef%b8%8f/

screenshot_2019-02-12 verandert das internet unsere liebe mozilla podcast about web

A quick fix would be to choose different background images for these posts, however this kind of issue is likely to keep coming up given the current design. A better fix may be to tweak the header design so that the title can work on top of any background colour.

craigcook commented 5 years ago

This is fixed in https://github.com/craigcook/mozilla-berlin-theme/commit/66f505390172ee5f1d4b23f7a588be007e45947f and pushed to production. I changed the gradient to a solid shaded bar.