search

mozilla / blok

Web Extension implementation of Firefox tracking protection for experimental development
https://public.etherpad-mozilla.org/p/tracking-protection-coordination
Mozilla Public License 2.0
25 stars 21 forks source link

The Tracking Protection icon is missing. #179

Closed zer09 closed 8 years ago

zer09 commented 8 years ago

The icon of the tracking proctection on the address bar is missing on some websites, like on google and youtube.

ff 49.0.1 Win 7 x64

Thanks

clemens-tolboom commented 8 years ago

I do not see the icon either.

@zer09 on what sites is it visible?

zer09 commented 8 years ago

As far as I remember it worked on

It's something it will work 50/50 (50% working, 50% fail).

clemens-tolboom commented 8 years ago

I can confirm the Icon appears on

It failed to appear on

zer09 commented 8 years ago

I see the same error on console log for http://regexlib.com/ but the icon is still there. I think the error does nothing for the Tracking Protection.

I also tried to enable/disable the Tracking Protection, and the error still persist. It could be it is a website error on the regexlib.com side.

groovecoder commented 8 years ago

This is by design ... see https://github.com/mozilla/blok/issues/11 ...

The tracking protection shield icon will only appear if the add-on blocks requests - made to 3rd party entities on the page.

The 3rd-party domains on youtube.com are all owned & operated by the "Google" entity in the entity list file, so the add-on does not block those requests, and so does not appear in the location bar.

clemens-tolboom commented 8 years ago

@groovecoder thanks for the explanation.

But you should show the shield in a inactive way to indicate the tool works IMHO.

And this group / entities list should be accessible through the UI. And preferable editable. I personally don't like the resources list as that looks to me ie Google / doubleclick is not blocked. (maybe I misunderstood this tool?)

groovecoder commented 8 years ago

We could change the UI to show the shield icon all the time, but that could also create user blindness to the feature, so (as with all UI) it's hard to harmonize all the goals. 😐

We intentionally left out displaying the tracking domains, groups, and entities to make the UI as simple as possible and to keep the focus on reporting problems & breakages. In addition, custom block- and entity-lists would make the reporting & breakage data much harder to analyze. (I.e., was the page broken because of a page-wide issue/bug, or did the user have a custom list configured?)

We will look at the data we're getting back, ask users some follow-up qualitative questions about the UI, and probably file new UI enhancements. This one is a good idea ... I'd probably like to A/B test this behavior if we can. We'll see ...