search

mozilla / blok

Web Extension implementation of Firefox tracking protection for experimental development
https://public.etherpad-mozilla.org/p/tracking-protection-coordination
Mozilla Public License 2.0
25 stars 21 forks source link

fix #193: update|change|restore toggle text #200

Closed groovecoder closed 8 years ago

groovecoder commented 8 years ago

Screenshots with the changed text:

txp-disabled txp-enabled
coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 46.237% when pulling 11e80fd183f75b9664ceebadbaf70f0d0859ea32 on toggle-text-193 into c8a1d079be1299d8f4f58b75dea4b1ca3f2aa8ca on master.

johngruen commented 8 years ago

Ship it

SoftVision-EmilPasca commented 8 years ago

I've verified this and it works on the latest (master) build v1.0.1 on Windows 10 x64 and Ubuntu 16.04 with the latest Nightly(52.0a1). Taking a closer look at this, I've observed that "Tracking Protection is disabled" text is now duplicated, once in the top side of panel and second, at the bottom side of the panel next to the toggle. Same goes for the case when "Tracking Protection is enabled". Is it really necessary to repeat ourselves ?

If we consider that is repetitive, I have some suggestions that I can share for this. Just let me know.