fix #166: use hidpi images for hidpi screens

mozilla / blok

Web Extension implementation of Firefox tracking protection for experimental development

https://public.etherpad-mozilla.org/p/tracking-protection-coordination

Mozilla Public License 2.0

25 stars 21 forks source link

fix #166: use hidpi images for hidpi screens #203

Closed groovecoder closed 8 years ago

groovecoder commented 8 years ago

@pdehaan or @rbillings - who wants to spot-check this on a HiDPI screen now?

coveralls commented 8 years ago

Coverage remained the same at 46.237% when pulling 7bb81f3200eccd4107e3c240d547a75178c6d629 on hidpi-icon-166 into c4a4f450ac23e34c0f880e3d4b6346d7b6a346e2 on master.

pdehaan commented 8 years ago

Not sure if these will work well after screenshotting, but here's what I'm currently seeing with my special eyes:

download_firefox_ _free_web_browser_ _mozilla Figure 1: 27" non-retina Dell.

download_firefox_ _free_web_browser_ _mozilla_and_fix__166__use_hidpi_images_for_hidpi_screens_by_groovecoder_ _pull_request__203_ _mozilla_blok

Figure 2: 15" rMBP.

pdehaan commented 8 years ago

TLDR: 👍 Looks great on my rMBP.

tracking-protection-disabled-16_png__16x16__and_tracking-protection-disabled-32_png__32x32__and_fix__166__use_hidpi_images_for_hidpi_screens_by_groovecoder_ _pull_request__203_ _mozilla_blok

Figure 3: Side-by-side of 16-vs-32px icons.

groovecoder commented 8 years ago

Thanks @fangshih for the HiDPI assets!