mozilla / blok

Web Extension implementation of Firefox tracking protection for experimental development
https://public.etherpad-mozilla.org/p/tracking-protection-coordination
Mozilla Public License 2.0
25 stars 21 forks source link

Too many messages in the browser console #220

Open kewisch opened 7 years ago

kewisch commented 7 years ago

I am getting constant messages in the browser console, to a point where I am having trouble debugging other add-ons.

This one comes for lots of request, particularly bad if you are on an AMO review page where there are background events ~ secondly:

00:47:10.612 Allowing request to domain NOT in the block-list. 1 background.bundle.js:308:7

These not so often, maybe every minute or two:

00:47:59.947 focusedWindow is undefined 1 background.bundle.js:353
    startWindowAndTabListeners/</< moz-extension://f77567f8-90a8-ef44-92b1-9367dbe712a7/js/background.bundle.js:353:1
    runSafeSyncWithoutClone resource://gre/modules/ExtensionUtils.jsm:71:14
    runSafeWithoutClone resource://gre/modules/ExtensionCommon.jsm:133:38
    wrapPromise/</< resource://gre/modules/ExtensionCommon.jsm:322:15
    withLastError resource://gre/modules/ExtensionCommon.jsm:262:14
    wrapPromise/< resource://gre/modules/ExtensionCommon.jsm:316:11
00:48:34.950 tab is undefined 1 background.bundle.js:362
    startWindowAndTabListeners/</< moz-extension://f77567f8-90a8-ef44-92b1-9367dbe712a7/js/background.bundle.js:362:7
    runSafeSyncWithoutClone resource://gre/modules/ExtensionUtils.jsm:71:14
    runSafeSync resource://gre/modules/ExtensionUtils.jsm:104:37
    runSafe resource://gre/modules/ExtensionCommon.jsm:123:32
    bound runSafe self-hosted:931:17
    wrapPromise/< resource://gre/modules/ExtensionCommon.jsm:310:31

I'd appreciate if you could fix these issues soon so I can keep this add-on enabled and take back control of my browser console. Testing on nightly 53.0a1 (2017-01-04) on mac.

wagnerand commented 7 years ago

The latter ones are actual errors.

Here is some more debug logging which should be removed or disabled with a pref to enable it:

13:00:25.050 **** tab changeInfo.status complete **** background.bundle.js:386:7 13:00:25.052 totalExecTime: undefined background.bundle.js:395:7 13:00:25.052 **** tab changeInfo.status complete **** background.bundle.js:396:7 13:00:25.472 **** tab changeInfo.status complete **** background.bundle.js:386:7 13:00:25.473 blocked 0 requests: Array [ ] background.bundle.js:388:9 13:00:25.474 from 0 entities: Array [ ] background.bundle.js:389:9 13:00:25.474 allowed 0 requests: Array [ ] background.bundle.js:392:9 13:00:25.475 from 0 entities: Array [ ] background.bundle.js:393:9 13:00:25.476 totalExecTime: 0 background.bundle.js:395:7 13:00:25.476 **** tab changeInfo.status complete **** background.bundle.js:396:7 13:00:25.478 browser.windows.onFocusChanged, windowID: 0 background.bundle.js:359:5 13:00:37.215 Allowing request from "undefined" origin - a browser internal origin. background.bundle.js:257:7 13:00:38.180 Allowing request to domain NOT in the block-list. background.bundle.js:308:7

yfdyh000 commented 7 years ago

Bug: https://github.com/mozilla/blok/search?q=production check not working. Add the console.log(process.env); into src\js\background.bundle.js, I got Object { } only; got undefined for console.log(process.env.MODE);.

groovecoder commented 7 years ago

Dang, looks like the latest .xpi was built without MODE=production 😢

Will need to see when we're taking Tracking Protection out of test pilot. We may not fix this until "phase 2" of tracking protection.