search

mozilla / blurts-addon

Mozilla Public License 2.0
5 stars 8 forks source link

Support If-Modified-Since/Last-Modified mechanism when fetching breach list to save bandwidth. r=johannh #102

Closed nhnt11 closed 6 years ago

nhnt11 commented 6 years ago

Spec is at https://github.com/mozilla/blurts-server/blob/master/controllers/hibp.js#L25

groovecoder commented 6 years ago

Code looks right, but did you do some spot-checking with some console output to show it's working?

nhnt11 commented 6 years ago

Yes, this code was tested manually. It works. :)

Not sure how to share that result here, I could take screenshots I guess?

groovecoder commented 6 years ago

Now that we know it works, we will also need to put some serious caching in front of our endpoint or Firefox clients are going to melt our poor little node app.

pdehaan commented 6 years ago

@nhnt11 Sorry, and just to confirm the latest UI for the add-on, you aren't displaying any logos or anything, correct?

nhnt11 commented 6 years ago

@pdehaan that's correct, no logos or anything.