search

mozilla / blurts-addon

Mozilla Public License 2.0
5 stars 8 forks source link

The icon for Firefox Monitor sometimes is not displayed #110

Closed obotisan closed 6 years ago

obotisan commented 6 years ago

[Affected versions]:

[Affected Platforms]:

[Prerequisites]: Prefs you'll need to set in about:config:

[Steps to reproduce]:

  1. Make sure that Firefox Monitor is enabled.
  2. Restart browser.
  3. Access in a new tab any of the sites from this list: https://docs.google.com/spreadsheets/d/1GYsLxXdCTlV5INzkpVBlpRPS3kfj-pTG7INOPSX6Up4/edit#gid=1389057478, but don't let it fully load (close the tab before the site fully loaded).
  4. Access the same link from step 3 in a new tab.

[Expected result]:

[Actual result]:

[Regression]: -I don't think this is a regression.

[Notes]:

nhnt11 commented 6 years ago

@obotisan In the gif, you are disabling the addon. Is this part of the STR? Please note that disabling the addon was not handled correctly and a fix has been submitted in PR #108. If this is an issue caused by disabling the addon, it will probably be fixed by that PR.

obotisan commented 6 years ago

Yes, I did. But I logged the issue because it happened in different circumstances, too. I only wrote those steps because using them the issue is reproducing all the time. We managed to reproduce the issue in other ways, but we didn't have clear steps for it. I thought that maybe it's a general issue and if you can fix this issue, it won't reproduce by using other steps.

nhnt11 commented 6 years ago

I don't have any ideas for how this could happen with #108 applied. The icon is set from code, not CSS, and the styling is done by existing browser styles, no custom styling is applied by the addon.

The only thing I can think of is, before #108, it would be possible that the icon asset is no longer available (if the addon is uninstalled for example) and therefore doesn't display. #108 should fix that.

obotisan commented 6 years ago

We verify the fix using RC 62.0 -build 2 on Windows 10 x64, Ubuntu 16.04 x64 an Mac OS 10.11. The bug is not reproducing anymore. I tried some different scenarios too, but I wasn't able to reproduce the issue.