search

mozilla / blurts-addon

Mozilla Public License 2.0
5 stars 8 forks source link

A few empty domains in breaches.json #50

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

Randomly spotted while trying to find domains w/ multiple breaches in the popup variants branch.

NOTE: Where ./breaches.json is a pretty-printed JSON file (via $ npx prettier breaches.json --write).

$ cat breaches.json | grep '"Domain": ""' -A1

    "Domain": "",
    "Title": "Anti Public Combo List",
--
    "Domain": "",
    "Title": "B2B USA Businesses",
--
    "Domain": "",
    "Title": "Coupon Mom / Armor Games",
--
    "Domain": "",
    "Title": "CrimeAgency vBulletin Hacks",
--
    "Domain": "",
    "Title": "Data Enrichment Records",
--
    "Domain": "",
    "Title": "Exploit.In",
--
    "Domain": "",
    "Title": "Exposed VINs",
--
    "Domain": "",
    "Title": "Master Deeds",
--
    "Domain": "",
    "Title": "Onliner Spambot",
nhnt11 commented 6 years ago

I don't think this issue is relevant anymore in its current form since we are dynamically downloading the json file.

pdehaan commented 6 years ago

FWIW, I'm still seeing this in the downloaded breaches. My guess is that user's would never see this via the add-on while browsing, but I guess they'd appear if they did a scan from the website and their email address was involved:

$ jq . src/breaches.json > src/breaches.pretty.json

$ cat src/breaches.pretty.json | grep '"Domain": ""' -B2

    "Title": "2,844 Separate Data Breaches",
    "Name": "2844Breaches",
    "Domain": "",
--
    "Title": "Anti Public Combo List",
    "Name": "AntiPublic",
    "Domain": "",
--
    "Title": "B2B USA Businesses",
    "Name": "B2BUSABusinesses",
    "Domain": "",
--
    "Title": "Coupon Mom / Armor Games",
    "Name": "CouponMomAndArmorGames",
    "Domain": "",
--
    "Title": "CrimeAgency vBulletin Hacks",
    "Name": "CrimeAgencyVBulletin",
    "Domain": "",
--
    "Title": "Data Enrichment Records",
    "Name": "DataEnrichment",
    "Domain": "",
--
    "Title": "Estonian Citizens (via Estonian Cybercrime Bureau)",
    "Name": "Estonia",
    "Domain": "",
--
    "Title": "Exploit.In",
    "Name": "ExploitIn",
    "Domain": "",
--
    "Title": "Exposed VINs",
    "Name": "VINs",
    "Domain": "",
--
    "Title": "Master Deeds",
    "Name": "MasterDeeds",
    "Domain": "",
--
    "Title": "Onliner Spambot",
    "Name": "OnlinerSpambot",
    "Domain": "",
--
    "Title": "Trik Spam Botnet",
    "Name": "TrikSpamBotnet",
    "Domain": "",