Nothing happens when clicking the "Firefox Monitor" and "Privacy Policy" hyperlinks from doorhangers

mozilla / blurts-addon

Mozilla Public License 2.0

5 stars 8 forks source link

Nothing happens when clicking the "Firefox Monitor" and "Privacy Policy" hyperlinks from doorhangers #51

Closed Softvision-CristinaBadescu closed 6 years ago

Softvision-CristinaBadescu commented 6 years ago

[Affected versions]:

Firefox Beta 61.0b14
Firefox Monitor 0.01, Branch 2, Branch 3, Branch 5

[Affected Platforms]:

All Windows

[Prerequisites]:

Have a clean Firefox profile with the latest Firefox Monitor v0.01 (custom built on 2018-06-20) installed.

[Steps to reproduce]:

Open the Firefox browser with the profile from prerequisites.
Navigate to a breached website ( eg. https://www.adobe.com).
Click the "Firefox Monitor" hyperlinked string and observe the behavior.

[Expected result]:

You are redirected to the Firefox Monitor Landing Page with the breached website.

[Actual result]:

Nothing happens.

[Notes]:

This issue is also reproducible with the "Privacy Policy" hyperlinked string.
This issue is not reproducible on Firefox Release 60.0.2.
Here is a screen recording with this issue:

pdehaan commented 6 years ago

Possibly similar/related to #47. Did you see any errors in your Browser Console?

Softvision-CristinaBadescu commented 6 years ago

Indeed, I get the following error in Browser Console "Error: Required argument triggeringPrincipal missing within openUILinkIn", therefore, this issue could have the same root cause as #47. I've closed this by mistake, but I'll reopen it and verify if the fix for #47 also fixes this issue. error browser console

Softvision-CristinaBadescu commented 6 years ago

Tested this with the latest Breach Alerts add-on (custom build on 06/27/2018) and the issue is still partially reproducible. After clicking the "Firefox Monitor" hyperlinked string, a new tab is opened but it's blank. breach alerts - 51

pdehaan commented 6 years ago

That "/?breach=undefined" in the URL (in the https://github.com/mozilla/blurts-addon/issues/51#issuecomment-400733803 GIF above) is highly suspicious.

UPDATE: Nevermind, I see that is reported as #70

nhnt11 commented 6 years ago

I just tested this in all variants and it seems to be fixed. please re-open if I'm wrong.

nhnt11 commented 6 years ago

The blank site is just because our production website is not up. I've been closing these issues to keep track of what I still need to do in this repo.

Softvision-CristinaBadescu commented 6 years ago

This issue is no longer reproducible using the latest "Firefox Monitor" add-on (0.01 custom built on 28.06.2018), on Firefox Release 61.0 unbranded build. Verified on Windows 7 x64. However, for certain websites, I'm also encountering the behavior described in #44.