search

mozilla / blurts-addon

Mozilla Public License 2.0
5 stars 8 forks source link

QA Fixes #57

Closed lesleyjanenorton closed 6 years ago

lesleyjanenorton commented 6 years ago

Fixes #6 Fixes #40 Fixes #42 Fixes #44 Fixes #47 Fixes #49 Fixes #51 Fixes #52

Addresses #33 but not a total fix because the study still runs in a private window if preferences are not explicitly set to always use tracking protection and always send DoNotTrack signal. Need a way to catch a private window.

// links going to breach details (http://monitor.firefox.com/?breach=host) will be accurate once PR #209 in blurts-server clears which lets the server query the db by domain in addition to name.

pdehaan commented 6 years ago

What’s the src/PwnedLogos.zip file?

pdehaan commented 6 years ago

Possibly easier to review https://github.com/mozilla/blurts-addon/compare/popup_variants...qa-fixes to see only the diffs between the popup_variants branch

nhnt11 commented 6 years ago

I'm going to merge this now and push follow-ups