mozilla / blurts-addon

Mozilla Public License 2.0
5 stars 8 forks source link

Calling "npm tests" causes failures due to missing npm scripts #78

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

https://github.com/mozilla/blurts-addon/blob/2e5c3d14ffad997e672159b80545cd438c323138/package.json#L52

$ npm test

> blurts-addon@1.0.0 test /Users/pdehaan/dev/github/mozilla/blurts-addon
> npm-run-all -n test:*

ERROR: Task not found: "test:*"
npm ERR! Test failed.  See above for more details.

$ echo $? # 1

The easiest solution is probably just do an "echo" in the npm test script saying "No tests found", similar to the npm init default test script:

"test": "echo \"Error: no test specified\" && exit 0"

But by exiting w/ a return code of 0, we wouldn't break any eventual CI (ref #74) or anything.