search

mozilla / blurts-addon

Mozilla Public License 2.0
5 stars 8 forks source link

WIP: Refactor repository for the post-shield world #90

Closed nhnt11 closed 6 years ago

nhnt11 commented 6 years ago

Makes everything shiny and removes shield code.

NOTE: Not to be merged yet!

pdehaan commented 6 years ago

I think we'll also need to make a few tweaks to the .eslintrc.js file:

diff --git a/.eslintrc.js b/.eslintrc.js
index b9746a4..115d82d 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -24,6 +24,21 @@ module.exports = {
         browser: true,
         webextensions: true,
       },
+      globals: {
+        EveryWindow: false,
+        gNotificationID: false,
+        HTML_NS: false,
+        PanelUI: false,
+        Preferences: false,
+        Services: false,
+        XUL_NS: false,
+      },
+    },
+    {
+      files: "scripts/*.js",
+      env: {
+        node: true,
+      },
     },
   ],
   parserOptions: {

I think most errors can be auto-fixed using $ npm run eslint -- --fix, but I think we'll still have around "✖ 12 problems (5 errors, 7 warnings)" which may need addressing.