search

mozilla / blurts-server

Mozilla Monitor arms you with tools to keep your personal information safe. Find out what hackers already know about you and learn how to stay a step ahead of them.
https://monitor.mozilla.org
Mozilla Public License 2.0
727 stars 205 forks source link

Make sure we cleverly specify if a breach has an SVG or PNG logo #153

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

Per https://github.com/mozilla/blurts-server/pull/151#discussion_r193541535...

This may be in some meta.LogoType property somewhere, but according to https://stage.haveibeenpwned.com/api/v2/breaches, it looks like the value will be either "png" or "svg".

lesleyjanenorton commented 6 years ago

I don't know if it counts as 'cleverly specified', given the amount of time it took me to arrive at a solution, but this should be resolved in #154

pdehaan commented 6 years ago

Super clever, love it!

pdehaan commented 6 years ago

Ingeniously fixed via #154, closing.

https://github.com/mozilla/blurts-server/blob/cdda1a945c8b495bb3ee5a68ae35ad926b344c5a/views/partials/banner_breach.hbs#L5 https://github.com/mozilla/blurts-server/blob/cdda1a945c8b495bb3ee5a68ae35ad926b344c5a/views/partials/compromised_accounts.hbs#L6