Closed groovecoder closed 6 years ago
@Micheletto - could aws elb or something else be messing with the If-Modified-Since
header on requests? I wrote a bunch of tests for this code and caught an unrelated bug, but nothing that would cause this behavior only on stage.
Moving this out of Launch Day milestone.
We can use Normandy and other roll-out prefs to mitigate the risk of clients overloading our servers ...
extensions.fxmonitor.breachListURL
set to https://monitor.firefox.com/hibp/breaches
extensions.fxmonitor.breachRefreshTimeout
set to 48 * 60 * 60 * 1000
(48 hours)Superseded by https://github.com/mozilla/blurts-server/issues/465
heroku app correctly responds with a 200 when the server's
req.app.locals.mostRecentBreachDateTime
is newer than theIf-Modified-Since
in the request:curl -v -H "If-Modified-Since: Mon, 3 Sep 2018 00:00:00 GMT" https://fx-breach-alerts.herokuapp.com/hibp/breaches
The same request on stage gets a
304
😢 :curl -v -H "If-Modified-Since: Mon, 3 Sep 2018 00:00:00 GMT" https://blurts-server.stage.mozaws.net/hibp/breaches