mozilla / blurts-server

Mozilla Monitor arms you with tools to keep your personal information safe. Find out what hackers already know about you and learn how to stay a step ahead of them.
https://monitor.mozilla.org
Mozilla Public License 2.0
710 stars 203 forks source link

Allow locale dependent URLs #604

Open flodolo opened 5 years ago

flodolo commented 5 years ago

We considered this a non blocker for launch, but it would be worth investigating.

Can we get https://monitor.firefox.com/cy to see the Welsh version?

Strictly related: should we have a language switcher to allow users to switch to a different language?

pdehaan commented 5 years ago

I was actually thinking of this again today while trying to scrape the site for different locales to take screenshots...

@flodolo Is this request more for front end users, or more for localizers wanting to quickly check translations without having to fiddle with their browser language settings?

Not sure if there would be an easy way to add support for variable routes based on locale name (like dynamically adding /cy and /cy?breach=LinkedIn from a list/array of supported locales; but possibly simple if we can convert the process.env.SUPPORTED_LOCALES into a friendly RegExp, like app.get(/.*fly$/, function (req, res) { res.send('/.*fly$/'); })), versus just toggling via a query parameter (a la monitor.firefox.com?locale=ru and monitor.firefox.com?breach=Adobe&locale=ru), where the locale= query param would override whatever is happening from fluent-langneg.

flodolo commented 5 years ago

Mostly user, I'd say.

Example scenarios:

Other reasons:

rraue commented 5 years ago

I can just support what @flodolo commented regarding search engines. The setup right now is not readable for most crawlers. Here a screenshot of Google in Germany:

Screenshot 2019-04-29 at 14 33 25

We need specific locale folders, a hreflang setup in the head so they are discoverable and ideal would be a language switcher like on www so users can switch if they would like to. The folders alone will not be enough, as most crawlers come with an english setup, but with hreflang it will be easy to connect and crawl all other available languages.

Happy to help with the international SEO and hreflang logic, if needed.

rraue commented 5 years ago

Any news on this issue? Especially with skyline coming soon, it will be harder to growth organically with the campaigns when minitor, send and lockwise will have only english appearance in german search results. The top suggestion searching for Firefox Monitor in germany is already "Firefox Monitor deutsch" asking if this service is available in german.

Screenshot 2019-08-15 at 12 21 12
groovecoder commented 5 years ago

@sandysage - can we consider this issue as a possible website enhancement between Skyline merge date and release?

EMMLynch commented 6 months ago

Closing since we've redesigned the site and functionality since this was created. If you feel that this is still needed, please let me know.

flodolo commented 6 months ago

This is still a problem that we should solve.