search

mozilla / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.
http://brackets.io
MIT License
176 stars 278 forks source link

Thimble is broken #153

Closed gideonthomas closed 9 years ago

gideonthomas commented 9 years ago

Reported by @KeniMorri and @K-LV screen shot 2015-03-30 at 3 55 27 pm is shown when we try to load thimble locally which uses whatevers on brackets:bramble

Seems like Thimble is not passing the "bramble:init" postMessage to brackets-browser-livedev which is why it never fulfils it's initExtension promise which is why it times out.

gideonthomas commented 9 years ago

The problem starts with this commit which allows thimble to use brackets from another domain

humphd commented 9 years ago

Paging @sedge...is this just locally or upstream too? NOTE you need to update your .env locally to get the right domains.

humphd commented 9 years ago

https://github.com/sedge/thimble.webmaker.org/commit/b63ece9ec6287694ee65c05fe21e39c3e9d575ff#diff-bb503f3d9047bcd4a5730559f1e16560R36 should be made smarter to know about port details, too. Question, why are we doing this parsing at all? Why not have different configs for different scenarios?

sedge commented 9 years ago

Let's do different configs - one for the origin that serves bramble and another for where the submodule is being served from.

It's the difference between someorigin.com and someorigin.com/subroute/[dist or src]

humphd commented 9 years ago

Who can work on this so we don't leave Thimble broken?

gideonthomas commented 9 years ago

fixed with https://github.com/sedge/thimble.webmaker.org/commit/16ce24c42b024e236d9f948c8c2a39a659baae03