Open humphd opened 8 years ago
This is only an issue in Bramble vs. Thimble, it seems, because in Thimble we always try to load an HTML file.
Please test my PR in https://github.com/mozilla/brackets/pull/625 with this bug, I might have fixed it when I rewrote that code.
I want to test it. I use following commands to download your branch, where are the codes it downloads to? This is the first time for me to test others' code.
git remote add "humphd" https://github.com/humphd/brackets.git
git fetch humphd
git remote add humphd https://github.com/humphd/brackets.git
git fetch humphd
git checkout livedev-fixes
I checkout to your branch, but I can't load the page. Error message is here.
Here are my branchs and remote
I would clear your cache. Let's discuss in class tomorrow too.
@peiying16 thanks for altering me to this--it was a bug in my code. I've pushed a new commit on my PR which fixes it. Do you mind trying again? Thanks for letting me know about this, I totally missed it!
@humphd Hello, I try your PR. Now I can load the page successfully, but it doesn't fix this issue. It is still 404
OK, this is helpful. Thank you. I think it's something to do with it trying to load an ImageView
vs. an HTML Live Document on startup, and not using a rewritten Blob URL. We'll have to debug this separate to what you're doing.
Thanks for you testing, I just hoped it would solve this bug, too.
NOTE: I have a fix for this in my work for #725, see https://github.com/mozilla/brackets/pull/725/commits/a122b49a16170be920610dd288273d2858cccfb6
STR: