Closed HansvandenPol closed 6 years ago
Good morning,
I was curious if someone could review my code.
<
This code checks for the 'BrambleMemoryFileSystem' parameter in the URL. When the parameter is given the memory-backed filesystem is used instead of the indexedDB filesystem.
@HansvandenPol it usually takes a week or more before code is reviewed. I'll do a pass over it now, and get @gideonthomas to look too.
@humphd Thanks for the review. I'm going to work on the changes now. One question though: when should I use the flags: ['FORMAT'] when creating the Filer.FileSystem object?
The only time to include flags: ['FORMAT']
is when you are actually formatting the filesystem in that one function call on 158. Otherwise, never do it explicitly.
@HansvandenPol any update here?
@humphd @gideonthomas Sorry for the late reply and thanks for the tips. I'll process them in my fix. I think I am able to complete the fix today. @gideonthomas I'd include the issue number in the next PR.
Thanks @HansvandenPol, this is definitely going to alleviate some of our existing loading errors in Thimble.
This code checks for the 'BrambleMemoryFileSystem' parameter in the URL. When the parameter is given the memory-backed filesystem is used instead of the indexedDB filesystem.