Stop reload of live dev preview

mozilla / brackets

An open source code editor for the web, written in JavaScript, HTML and CSS.

http://brackets.io

MIT License

176 stars 278 forks source link

Stop reload of live dev preview #903

Closed ericschv closed 6 years ago

ericschv commented 6 years ago

Created preference in LiveDevMultiBrowser.js designed to disable live dev preview whenever a user imports files. Inside of src\filesystem\impls\filer\lib\FileImport.js I disable live dev preview before the import and then undo it after files are loaded.

This fix addresses the bug issue 2446 from the Thimble repo.

Link to the issue: https://github.com/mozilla/thimble.mozilla.org/issues/2446

humphd commented 6 years ago

@ericschv I think you know this, but in case not, you're failing lint:

/home/travis/build/mozilla/brackets/src/LiveDevelopment/LiveDevMultiBrowser.js
  978:40  error  'S' is not defined  no-undef
  978:41  error  Missing semicolon   semi
✖ 2 problems (2 errors, 0 warnings)

Can you fix those two issues and push a new commit?

ericschv commented 6 years ago

@humphd yes I am aware. I will make the commit now.

ericschv commented 6 years ago

@humphd I made the changes you requested

gideonthomas commented 6 years ago

Thanks @ericschv, nice work!