search

mozilla / browsertime

Your browser, your page, your scripts!
Apache License 2.0
5 stars 7 forks source link

First Contentful Paint metric is stored in a different json object depending on the host app (Chrome vs Gecko) #39

Open acreskeyMoz opened 5 years ago

acreskeyMoz commented 5 years ago

Looking at the browsertime.json for Gecko we find First Contentful Paint here: [0].statistics.timings.timeToContentfulPaint

And in Chrome it's output here: [0].statistics.timings.paintTiming.first-contentful-paint

This is problematic for performance tooling.

Even if the user agents implement this paint timing metric in a different manner, I feel that browsertime should be consistent in its output.

acreskeyMoz commented 5 years ago

I can take this one in a bit. If the change should be made upstream, I can make it there and bring it back to this branch.

ncalexan commented 5 years ago

I can take this one in a bit. If the change should be made upstream, I can make it there and bring it back to this branch.

I agree that Browsertime should be consistent across UAs, and agree that this should be addressed upstream (if it hasn't already been addressed).

Just FYI, I merged in upstream (https://github.com/ncalexan/browsertime/tree/v6.0.0-alpha.5-android) but haven't pushed to m/b 'cuz Geckodriver + Android is still outstanding. So there's hope for "just" fixing it upstream in the near future.

gmierz commented 5 years ago

Another metric Chrome browsertime data is missing is timeToDomContentFlushed.