search

mozilla / bugbot

A Mozilla release management tool to send reminders to Firefox developers and improve Bugzilla metadata
BSD 3-Clause "New" or "Revised" License
41 stars 68 forks source link

[assignee_no_login] TypeError: UserActivity.get_string_status() missing 1 required positional argument: 'user_creation_time' #2515

Closed benjaminmah closed 1 month ago

benjaminmah commented 1 month ago 
Traceback (most recent call last):
  File "/Users/bmah/bugbot/bugbot/bzcleaner.py", line 856, in run
    self.send_email(date=date)
  File "/Users/bmah/bugbot/bugbot/bzcleaner.py", line 772, in send_email
    data = self.get_email_data(date)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/bmah/bugbot/bugbot/bzcleaner.py", line 690, in get_email_data
    bugs = self.get_bugs(date=date)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/bmah/bugbot/bugbot/rules/assignee_no_login.py", line 63, in get_bugs
    bugs = self.handle_inactive_assignees(bugs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/bmah/bugbot/bugbot/rules/assignee_no_login.py", line 87, in handle_inactive_assignees
    bug["assignee_status"] = user_activity.get_string_status(
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: UserActivity.get_string_status() missing 1 required positional argument: 'user_creation_time'
suhaibmujahid commented 1 month ago

Regressed by https://github.com/mozilla/bugbot/pull/2457

suhaibmujahid commented 1 month ago

I would suggest drop user_creation_time as a paramenter in get_string_status(). For new users, we could have a new status instead (e.g., INACTIVE_NEW).