search

mozilla / bugbot

A Mozilla release management tool to send reminders to Firefox developers and improve Bugzilla metadata
BSD 3-Clause "New" or "Revised" License
41 stars 68 forks source link

Need-info authors of performance regression patch in perf-alert bugs after 1 week of no activity #2526

Closed gmierz closed 3 weeks ago

gmierz commented 3 weeks ago

We'd like to have bugbot make comments, and need-info the authors of patches that cause performance alerts after 1 week of no activity.

Here's an example perf-alert bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1924102

The author of the regressing patch can be found in the Regressed by field for the bug. The comments should only happen on bugs that were created for performance regressions. It should exclude these kinds of bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1909343

The bugs we want to target are those which contain both of these keywords: perf-alert, and regression.

marco-c commented 3 weeks ago

@gmierz do you currently do this manually? I just want to figure out if this would increase the number of needinfos overall, or just switch them from being set by a human to being set by the bot.

gmierz commented 3 weeks ago

We don't currently do this manually. We were considering it, but it would be too much additional work for perf-sheriffs to take on so we need an automated approach for it.

Looking at this dashboard here: https://sql.telemetry.mozilla.org/queries/103165/source?p_alert_summary_id=null&p_framework=browsertime&p_past_months=1&p_platform=null&p_status=null&p_suite=null&p_test=null

I see about 9 bugs in the last month that would have received a needinfo.

marco-c commented 3 weeks ago

OK, that sounds reasonable.

gmierz commented 3 weeks ago

PR is up here in draft form atm: https://github.com/mozilla/bugbot/pull/2527