search

mozilla / bugzy

A bugzilla client for the Activity Stream Team
https://www.bugzy.org
10 stars 13 forks source link

refactor: Upgrade to parcel v2 and node 19 #260

Closed aminomancer closed 1 year ago

aminomancer commented 1 year ago

Closes #211

aminomancer commented 1 year ago

This also fixes the regression from a couple months ago where the content bundle ends up importing server code. I would also like to fix the reverse issue, where the server bundle imports content code. But that would better be resolved in whatever PR we come up with that deals more broadly with organizing our typings.

Anyway, this is a pretty colossal change - it's just not possible to make incremental improvements here since parcel v1 to v2 is a total paradigm shift. It forces a lot of changes. I would appreciate any help testing this, so I don't miss any subtle issues.

We have to rename all the CSS modules because the alternative is to parse ALL stylesheets as modules, which breaks index.scss. With no way to exclude individual stylesheets from that behavior. Another alternative would be importing index.scss in index.tsx, but I just generally don't like the idea of precluding global stylesheets.