search

mozilla / build-tooltool

A tool for fetching binary artifacts for builds and tests
5 stars 16 forks source link

Don't keep sessions open while doing multi-second operations #16

Closed djmitche closed 9 years ago

djmitche commented 9 years ago

@Callek r?

Callek commented 9 years ago

merely skimmed the tests and they look good, but as noted above I think the badpenny tasks's final commit() needs to exist. (or we should commit at the point where we delete, but before we return)

Callek commented 9 years ago

:+1: with that addressed (no need for a second look)