search

mozilla / cargo-vet

supply-chain security for Rust
Apache License 2.0
649 stars 43 forks source link

Configurable default review name & email #485

Open repi opened 1 year ago

repi commented 1 year ago

I believe right now when doing a review through the CLI the who line is derived from git with name and email? Believe this is a good default but it would be nice to be able to override it for example with an environment variable so one can route it differently without having to edit the review after the fact.

For example we at Embark (audits) don't use our personal or work emails for the reviews, instead preferring to us our public mailing list of opensource@embark-studios.com as a central contact point.

Could for example have optional env vars for overriding the who user name and email, potentially called something like CARGO_VET_USER and CARGO_VET_EMAIL that if available replaces the git user info.

If aligned, I can probably implement and add such support in a PR.

bholley commented 1 year ago

That seems sensible. @mystor WDYT?

mystor commented 1 year ago

This seems reasonable to me. Using naming like CARGO_VET_NAME and CARGO_VET_EMAIL to align with the git environment variables seems like a solid environment variable naming approach (https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables#_committing).

cfm commented 11 months ago

This is a drive-by vote for environment variables over (or in addition to) the configuration file proposed by #557. :-)