Calling source graph with `?visible=1000000` ends in 500

mozilla / cargo-vet

supply-chain security for Rust

Apache License 2.0

621 stars 43 forks source link

Calling source graph with `?visible=1000000` ends in 500 #578

Closed cemoktra closed 5 months ago

cemoktra commented 8 months ago

Using ?visible=1000000 causes 500 on sourcegraph.com, e.g.:

https://sourcegraph.com/crates/openapiv3/-/compare/v1.0.2...v1.0.3?visible=1000000

vs https://sourcegraph.com/crates/openapiv3/-/compare/v1.0.2...v1.0.3

cemoktra commented 8 months ago

This specifically relates to https://github.com/search?q=repo%3Amozilla%2Fcargo-vet%201000000&type=code

I dont know why that changed on sourcegraph, but either removing that number completely or reducing it should help

cemoktra commented 8 months ago

7000 works, 7500 no

jdorfman commented 8 months ago

Thanks @cemoktra looking into it.

cemoktra commented 7 months ago

This now ends in 400 but still not working. The message returned is: query exceeds maximum query cost

jdorfman commented 7 months ago

@cemoktra @bholley unfortunately, we had to put the visible limit back. Bots have been abusing the ?visible=1000000 query string which drove up costs and slowed the service down for others.

cemoktra commented 7 months ago

@jdorfman can you tell the limit? I can prepare an according MR then

jdorfman commented 7 months ago

@cemoktra 5 e.g. https://sourcegraph.com/crates/openapiv3/-/compare/v1.0.2...v1.0.3?visible=5

cemoktra commented 7 months ago

No I mean the maximum.

bholley commented 5 months ago

Looks like the new limit is a bit north of 7000. I'll prepare a patch.