Additional tracing messages to diagnose missing audit criteria.

mozilla / cargo-vet

supply-chain security for Rust

Apache License 2.0

621 stars 43 forks source link

Additional tracing messages to diagnose missing audit criteria. #592

Closed anforowicz closed 3 months ago

anforowicz commented 4 months ago

This PR helped me diagnose problems I've encountered when trying to import https://raw.githubusercontent.com/google/rust-crate-audits/main/manual-sources/google3-audits.toml into Chromium (see Chromium's config.toml here).

PTAL?

anforowicz commented 4 months ago

/cc @danakj

anforowicz commented 3 months ago

Thanks for reviewing @mystor. Can you PTAL again?

anforowicz commented 3 months ago

Thanks for the review @mystor!

Two quick notes:

I have a separate PR to clean up Clippy and warnings: https://github.com/mozilla/cargo-vet/pull/598
It seems to me that this PR passes cargo test on CI. My local cargo insta state somehow got messed up and I see cargo test failures locally, but I assume that this is just happening on my machine and shouldn't block this PR.

mystor commented 3 months ago

It seems to me that this PR passes cargo test on CI. My local cargo insta state somehow got messed up and I see cargo test failures locally, but I assume that this is just happening on my machine and shouldn't block this PR.

This is actually #602 as far as I can tell, and those failures should be fixed now since #603.

anforowicz commented 3 months ago

Thanks for the other upstream fixes. FWIW cargo clippy and cargo test pass locally for me, and cargo fmt produces no changes. So maybe let me rebase and squash these changes and this will help make the CI happy?

mystor commented 3 months ago

Thanks!