mozilla / cargo-vet

supply-chain security for Rust
Apache License 2.0
654 stars 44 forks source link

Clean up `rustc` and `clippy` warnings. #598

Closed anforowicz closed 6 months ago

anforowicz commented 6 months ago

This addresses the warnings reported in https://github.com/mozilla/cargo-vet/actions/runs/8444313897/job/23159306099

For more detailsa about the rationale for the clippy-related changes, see:

anforowicz commented 6 months ago

AFAIU tokio::sync::SemaphorePermit is not supposed to be read:

Not sure if some additional follow-up may be needed here. I wondered about reporting this at https://github.com/rust-lang/rust/issues/new, but I guess not all drop methods count as using a field (Vec's drop probably wouldn't count). So I guess just allowing "dead code" here is a reasonable workaround.

anforowicz commented 6 months ago

Ooops... I didn't run cargo fmt... This should be fixed now in https://github.com/mozilla/cargo-vet/commit/008636f7b4d06f7ebb66160639835bf0c4173bfa