search

mozilla / cbindgen

A project for generating C bindings from Rust code
Mozilla Public License 2.0
2.37k stars 306 forks source link

Upgrade clap 3 to clap 4 #847

Closed boxdot closed 1 year ago

boxdot commented 1 year ago

This also removes the dependency on the unmaintained crate atty.

Closes #828

jschwe commented 1 year ago

What is the current minimum supported Rust version for clap 4? Currently the msrv for cbindgen is 1.57, so that would presumably need to be bumped too.

boxdot commented 1 year ago

@jschwe Indeed, thank you. I updated the version in Cargo.toml. Is it ok to increase it, or does cbindgen has a hard MSRV requirement?

jschwe commented 1 year ago

As far as I know (but I'm not a maintainer) there currently is no official MSRV policy. I don't know if cbindgen is used in Firefox, but I could imagine the firefox msrv policy applies also to cbindgen:

We will update the Minimum Supported Rust Version (MSRV) when required.

romanofski commented 1 year ago

Hi! Would it possible to merge this and cut a new release?

romanofski commented 1 year ago

Hope I'm not overstepping but pinging @emilio if a merge and release is possible. Sorry otherwise.

jschwe commented 1 year ago

The PR breaks the "Test package" test in CI (which I can reproduce locally), therefore I propose reverting it for now in #868.