search

mozilla / chat.mozillafoundation.org

Open source Slack-alternative in Golang and React - Mattermost
http://mattermost.org
Other
5 stars 6 forks source link

Add user preference for disabling auto-preview of embeds #27

Open alanmoo opened 8 years ago

alanmoo commented 8 years ago

Some people don't like gifs and would rather not see them when a link is sent to a channel.

Pomax commented 8 years ago

even people who do like gifs might not like to lose a productive conversation because someone decided to drop a gif and push twenty lines of chat off the visual buffer with it. The ideal situation would be a user-preference "master" control (affecting all channels), with a hot toggle for individual channels (defaulting to the user's preference, but overriding it when toggled), as well as a hot toggle for individual entries (defaulting to the channel setting, which means it also defaults to the user's pref, but overriding when toggled)

alanmoo commented 8 years ago

The hot toggle is already built in to our instance, so the user preference applying to either the entire instance or specific channels sounds like a welcome addition.

alanmoo commented 8 years ago

I should note that if a user has "hide embeds by default" enabled, there are probably some optimizations that can be done to prevent them from being fetched immediately.

Pomax commented 8 years ago

ah, that's not a bad idea. Links take up as many bytes as the link is long, not prefetching content for inlining saves b/w