search

mozilla / chronicle

find everything you've ever found
http://mozillachronicle.tumblr.com/
Mozilla Public License 2.0
16 stars 6 forks source link

Unused commander dependency #331

Closed pdehaan closed 9 years ago

pdehaan commented 9 years ago

Steps to reproduce:

  1. Install npm-check module.

  2. Run the following on the command line:

    $ npm-check

wreck          NOTUSED?  Possibly never referenced in the code.
                    npm uninstall --save wreck to remove.

commander      NOTUSED?  Possibly never referenced in the code.
                    npm uninstall --save commander to remove.

Use npm-check -u for interactive update.

    I did a bit of light grep action and it seems that both modules are currently unused in the project.

    $ grep -irn "commander" . --exclude-dir=node_modules --exclude=npm-shrinkwrap.json
./bin/migrate.js:9:// TODO bring back commander, I guess
./package.json:12:    "commander": "2.6.0",

$ grep -irn "wreck" . --exclude-dir=node_modules --exclude=npm-shrinkwrap.json
./package.json:31:    "wreck": "5.1.0"
pdehaan commented 9 years ago

I'm happy to remove the dependencies and regenerate the shrinkwrap file, but it's possibly the lowest priority bug in the GitHubs.

pdehaan commented 9 years ago

Removed wreck dependency in #342.

pdehaan commented 9 years ago

Re: Unused commander module, there was a reference in the /bin/migrate.js:9 saying:

TODO bring back commander, I guess

I'm fine with closing out this silly bug, or we can leave it open as a reminder to convert ./bin/migrate.js to use commander (or ultimately remove that dependency).

pdehaan commented 9 years ago

Closing this for now...

Updated the Chronicle Prerelease Deployment Checklist which outlines using npm-check module to check for orphaned modules in package.json.