search

mozilla / chronicle

find everything you've ever found
http://mozillachronicle.tumblr.com/
Mozilla Public License 2.0
16 stars 6 forks source link

include extractedUrl, extractedProviderUrl, and title when searching? #334

Closed pdehaan closed 9 years ago

pdehaan commented 9 years ago

Per https://github.com/mozilla/chronicle/pull/329#discussion_r24628825 and #324:

Unrelated, but should we also be searching extractedUrl, extractedProviderUrl, and/or title?

Basically, "title" because the extractedTitle will be less useful if the scraped page was behind a login (ie: facebook, or something on localhost that embedly can't touch).

@nchapman said "Good points. Let's do a follow up PR for these. @pdehaan will you create an issue?"

THIS IS THAT ISSUE!!!

pdehaan commented 9 years ago

Fixed in #337 (plus I added extractedLead on the off chance that I see it eventually filled with some sort of content).