mozilla / chronicle

find everything you've ever found
http://mozillachronicle.tumblr.com/
Mozilla Public License 2.0
16 stars 6 forks source link

style(dates): make date markers pretty #341

Closed johngruen closed 9 years ago

johngruen commented 9 years ago

This should get merged after #340

pdehaan commented 9 years ago

chronicle Figure 1: The bottom of the date marker is a bit touchy on the first history item.

johngruen commented 9 years ago

@pdehaan gap issue fixed!

pdehaan commented 9 years ago

Much nicer! I'll need to tweak my local data some more since it seems to enter all the visits for the same day, but I did notice a super edge case where you spend 4 minutes deleting all your visits, the date header still remains. But we can file that as a separate issue and handle it later.

chronicle Figure 2: Date header remains after you delete all your visits.

pdehaan commented 9 years ago

Possibly less edge case? I hacked my ./bin/create_test_data.js to create data for random days and then I deleted items and it looks roughly like this. Actually, probably the same issue as my previous comment, just funnier results with multiple stacked day labels:

chronicle Figure 3: January 4th January 3rd January 2nd

nchapman commented 9 years ago

Hooray! :+1:

nchapman commented 9 years ago

Date header remains after you delete all your visits.

@pdehaan will you create a new issue for this?

pdehaan commented 9 years ago

@nchapman Filed as #350