mozilla / chronicle

find everything you've ever found
http://mozillachronicle.tumblr.com/
Mozilla Public License 2.0
16 stars 6 forks source link

Chronicle test data should create visits over multiple days #345

Closed pdehaan closed 9 years ago

pdehaan commented 9 years ago

Found during testing #341. From /bin/create_test_data.js:35-36:

We'll use this date as a starting point for generating records. Each successive record will be a number of seconds in the future.

visitedAt: new Date(historyDate.getTime() + (1000 * 60 * n)).toJSON()

Basically all the test results are loaded into the same day. We should probably bump it up to a handful of results for each day so we can test headers and deleting a bit easier.

pdehaan commented 9 years ago

Attempted fix made in #346

jaredhirsch commented 9 years ago

I wonder if it would be good to extract the dates out into the json file that contains the visit URLs, so that we can easily experiment with, say, UI for users who have been gone for a few weeks, then return.

I'll leave that as something to think about for later.