search

mozilla / code-review

Automated static analysis & linting bot for Mozilla repositories
Mozilla Public License 2.0
56 stars 42 forks source link

Detect issues coming from a parent revision #1705

Open vrigal opened 1 year ago

vrigal commented 1 year ago

Ref. https://github.com/mozilla/code-review/pull/1581#discussion_r1184883519

That feature was lost with the before/after implementation because issues detected outside the diff are now published (when the feature runs). I is possible to use the IssueList endpoint to list issues matching the repository/parent revision changeset, then explicitly display it in Phabricator. Parent revisions can be retrieved via Phabricator libmozdata client - api.load_parents(revision.phabricator_phid).

marco-c commented 1 year ago

The implementation for this should be similar to the one we have to check differences in issues between diffs in the same revision.