don't create try pushes for old phabricator revisions

mozilla / code-review

Automated static analysis & linting bot for Mozilla repositories

Mozilla Public License 2.0

56 stars 42 forks source link

don't create try pushes for old phabricator revisions #2124

Closed jcristau closed 6 days ago

jcristau commented 7 months ago

If reviewbot fails to create a try push for a given phabricator revision in some time (1 hour?), it should give up instead of holding on to it forever.

We're seeing an issue right now where reviewbot is delayed making try pushes by 2 days.

marco-c commented 7 months ago

This would be fixed around here: https://github.com/mozilla/libmozevent/blob/a41fad391146bbdc182b3bcc295353c30f76bfbc/libmozevent/mercurial.py#L357.

marco-c commented 7 months ago

We should return a failure and post to Phab that we run out of time.

La0 commented 1 week ago

we should check the age of the build there as there are other stop conditions
the age is obtainable through PhabricatorBuild.diff.[some path in JSON]

La0 commented 6 days ago

Side note: we need this patch to test deployment of #2449 (if we need to get some downtime, it will spam with try pushes otherwise)

marco-c commented 6 days ago

This is fixed in libmozevent, we just need to upgrade the lib.