mozilla / code-review

Automated static analysis & linting bot for Mozilla repositories
Mozilla Public License 2.0
56 stars 42 forks source link

Also migrate char, line and nb_lines attributes to IssueLink #2511

Closed vrigal closed 2 weeks ago

vrigal commented 2 weeks ago

Follow up #2473

La0 commented 2 weeks ago

I was thinking that we could probably do a single SQL subquery by writing it directly in sql (should be faster instead of making 5 subqueries).

Something like

update issues_issuelink as link
set 
  in_patch=i.in_patch,
  new_for_revision=i.new_for_revision,
  char=i.char,
  line=i.line,
  nb_lines=i.nb_lines
from issues_issue as i
where i.id = link.issue_id
La0 commented 2 weeks ago

Closing in favor of #2513