search

mozilla / code-review

Automated static analysis & linting bot for Mozilla repositories
Mozilla Public License 2.0
56 stars 42 forks source link

Do not crash on unsupported tasks #2514

Closed La0 closed 2 weeks ago

La0 commented 2 weeks ago

Closes #2508

The bug is trivial to fix, but the task that triggered the exception is unsupported.

A log line now mentions it in the bot execution with this patch:

2024-11-13 09:38:44.000441 [WARNING ] [warning  ] Missing firefox-source-docs-url.txt
2024-11-13 09:38:44.000442 [WARNING ] [warning  ] An erroneous task processed some artifacts and found no issues or patches id=BHDyOiRpTeCWly7D90XTNw task=source-test-doc-upload

As mentionned, this is due to public/firefox-source-docs-url.txt artifact missing. We cannot do much more on the bot side

marco-c commented 2 weeks ago

The issue is also reported by this other task: https://firefox-ci-tc.services.mozilla.com/tasks/bDCAukbsSuqVpWTHDRd1CQ. This one should be supported by the bot.