search

mozilla / codemoji

Mozilla Foundation project to support 2016 Encrypt campaign
Mozilla Public License 2.0
22 stars 19 forks source link

currkey not defined #212

Open abusedmedia opened 8 years ago

abusedmedia commented 8 years ago

Hi @cadecairos

I've seen you've fixed the currkey definition but it doesn't work on mobile yet.

After a bit of investigation it looks like uglify, in you're build system, doesn't handle properly that variable during minification process (basically it strips the definition you put and few lines below a statement try to use that variable without success, throwing the error). This doesn't happen in my build process though, this is why it came up recently.

Long story short: I cannot fix it since it's a builder (gulp/uglify) issue, maybe it's a node_module version issue... don't know.. hope this help, though.

cadecairos commented 8 years ago

It seems to work for me on firefox for Android - which device/browser is it not working on?

abusedmedia commented 8 years ago

iOS, but you can also see the issue using Chrome with mobile simulator, in console you'll see the error.

Pomax commented 8 years ago

are the specific steps I can take to see this error? I just cloned master and ran it through the build process, but this does not yield any errors in Chrome with mobile emulation turned on set to iPhone 6

cadecairos commented 8 years ago

I think this happened because I build using node 6 - but staging and production (once we switch to codemoji.org ) will build with node ^4.4.7 - and I don't see the error in that case

abusedmedia commented 8 years ago

@cadecairos is right, the current codemoji.org version doesn't have the issue.