search

mozilla / connect-cachify

Express connect middleware to provide easy frontend caching for Node.js
Mozilla Public License 2.0
132 stars 21 forks source link

Updated to support Express 4.x #42

Closed kmchugh closed 10 years ago

kmchugh commented 10 years ago

Express 4.x no longer represents res.locals as a function, this fix allows the treatment of res.locals as an object for 4.x and keeps backwards compatibility in 3.x and 2.x.

This also fixes up race conditions in express-test.js

shane-tomlinson commented 10 years ago

@kmchugh - Thanks for the PR Ken! I am sorry that it has taken so long to get it looked at. I have done an initial code review and things are looking great. I have not tested yet, but the one blocker I see for merge is spacing. Can you go back to the original formatting and use 2 space tabs?

shane-tomlinson commented 10 years ago

@kmchugh - I am closing this and opening a new PR with my requests. Thank you very much!

kmchugh commented 10 years ago

Thanks Shane, Much appreciated!

On Fri, May 9, 2014 at 11:53 PM, Shane Tomlinson notifications@github.comwrote:

@kmchugh https://github.com/kmchugh - I am closing this and opening a new PR with my requests. Thank you very much!

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/connect-cachify/pull/42#issuecomment-42681630 .