mozilla / contain-facebook

Facebook Container isolates your Facebook activity from the rest of your web activity in order to prevent Facebook from tracking you outside of the Facebook website via third party cookies.
Mozilla Public License 2.0
975 stars 176 forks source link

cannot login to blablacar.co.uk with facebook #121

Closed demoklion closed 5 years ago

demoklion commented 6 years ago

Issue

Facebook login doesn't work on https://www.blablacar.co.uk/login

Actual behavior

Flashes some tiny window, then opens

https://www.facebook.com/v2.9/dialog/oauth?app_id=123152947759014&channel_url=https%3A%2F%2Fstaticxx.facebook.com%2Fconnect%2Fxd_arbiter%2Fr%2FFdM1l_dpErI.js%3Fversion%3D42%23cb%3Df1548417b2d412%26domain%3Dwww.blablacar.co.uk%26origin%3Dhttps%253A%252F%252Fwww.blablacar.co.uk%252Ff318e6f0e2bf92%26relation%3Dopener&client_id=123152947759014&display=popup&domain=www.blablacar.co.uk&e2e=%7B%7D&locale=en_US&origin=1&redirect_uri=https%3A%2F%2Fstaticxx.facebook.com%2Fconnect%2Fxd_arbiter%2Fr%2FFdM1l_dpErI.js%3Fversion%3D42%23cb%3Df23d41d9025826%26domain%3Dwww.blablacar.co.uk%26origin%3Dhttps%253A%252F%252Fwww.blablacar.co.uk%252Ff318e6f0e2bf92%26relation%3Dopener%26frame%3Df165f0615af9cc8&response_type=token%2Csigned_request&scope=email%2Cuser_birthday%2Cpublic_profile%2Cuser_friends&sdk=joey&version=v2.9

in the Facebook container in a new tab.

Expected behavior

Opens a window to fill-in Facebook login (or just flashes it for a second, since I'm already logged in to Facebook), then closes the window and redirects me to blablacar.co.uk's main page.

Steps to reproduce

  1. Disable built-in Tracking Protection
  2. click Continue with Facebook

Notes

..

TanviHacks commented 6 years ago

Login with facebook does not always work with this extension. If a third party uses login with facebook and acheives the login flow by using url parameters, this will work. If not, then it will not.

This is by design - because if you logged in with facebook in your regular Container, then facebook would have your identity outside the Facebook Container. The point of the extension is to make sure this doesn't happen. This is also noted here - https://support.mozilla.org/en-US/kb/facebook-container-prevent-facebook-tracking#w_how-does-this-affect-facebookaos-features

ryanfeeley commented 6 years ago

@TanviHacks We have to do more to support the use case of adding other sites into the Facebook container. Firefox cannot become the browser that you can't use for Pinterest, Airbnb and the thousands of other sites that offer sign in with Facebook. Add-ons do allow us to do what I've mocked up below, however websites load content from many domains. It will have to be smart about it.

image
demoklion commented 6 years ago

@TanviHacks seems this issue is better described in #27, you can remove or merge this one with it.

maxxcrawford commented 5 years ago

We have this issue on going in #422. Closing this and adding the domain there to be included in testing. Thanks!