mozilla / contain-facebook

Facebook Container isolates your Facebook activity from the rest of your web activity in order to prevent Facebook from tracking you outside of the Facebook website via third party cookies.
Mozilla Public License 2.0
988 stars 177 forks source link

content_script.css turns body text to black globally #866

Closed aaronsantiago closed 2 years ago

aaronsantiago commented 2 years ago

My local installation of the Facebook Container plugin includes a content_script.css with this text:

body {
    --blue60: #0060df;
    --blue70: #003eaa;
    --primaryText: #15141A;
    --secondaryText: #5B5B66;
    --grey20: #ededf0;
    --light-gray: #F0F0F4;
    --white: #ffffff;
    --transition: all .15s cubic-bezier(.07,.95,0,1);
    --borders: 1px solid #ededf0;
    font-size: 13px;
    font-weight: 400;
    color: #15141A;
    font-family: "SF Pro Text", 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif;
}

Turning the text on many websites, including GitHub and Slack, black. In dark mode these sites become unreadable.

Available workarounds:

divyeshsachan commented 2 years ago

I confirm this issue. Extension is injecting css file in all tabs which is causing pages in all tabs to change font/size, etc.... This is happening with today's release of 2.3.3.

dylemma commented 2 years ago

image Can confirm 🤣

ubald commented 2 years ago

Changing the color in the inspector makes it persist across reloads too.

divyeshsachan commented 2 years ago

The only solution is to disable "Facebook Container" till it is fixed in next release.

weaversam8 commented 2 years ago

Is it possible to rollback 2.3.3? Or do they need to create a new release?

dylemma commented 2 years ago

Changing in the inspector seems to work, but on a per-domain basis. I fixed it on one site in the inspector, and it persists as @ubald said, but the issue is still present on other sites.

aaronsantiago commented 2 years ago

Another workaround is to use Stylus etc. with a global userstyle. I use global dark style

weaversam8 commented 2 years ago

It looks like they've already released a patched version, 2.3.4: https://addons.mozilla.org/en-US/firefox/addon/facebook-container/versions/

Uninstalling and reinstalling the extension should fix it.

xigoi commented 2 years ago

How did this even happen? How do you accidentally make an extension for isolating Meta websites inject a random stylesheet on all websites?

andyross63 commented 2 years ago

Looking in the pulls section, it looks like 2.3.4 is actually just 2.3.2 repackaged.

groovecoder commented 2 years ago

Thanks everyone for the quick feedback on this. We will be more diligent about testing website compatibility in the future.

90K users received the buggy 2.3.3 version, and now 109K users are on the latest 2.3.4 (i.e., the rollback) version. 1.1M users are still on 2.3.2, but their next update should jump them straight to 2.3.4 instead of the buggy 2.3.3.

We are working on a full fix to include the security improvements, performance improvements, AND the bug-fix for the styling issue.