bug: css affect to website which has css contain .is-hidden class

[ghost]

https://github.com/mozilla/contain-facebook/blob/a7a39f46486b8455d1de24bfba39e65ec95aa06c/src/content_script.css#L352ass

I have access a website which contains .is-hidden class inside. When I turn on facebook container extension, it hides this class. I've seen patch to fix this (in file content_scipt.css). But it doesn't seem to work or maybe your app hasn't deployed yet . Please review it, thank you at all.

[krystian3w]

maybe your app hasn't deployed yet

Yes, commit https://github.com/mozilla/contain-facebook/commit/a7a39f46486b8455d1de24bfba39e65ec95aa06c don't arrived to public signed xpi (made on 5 Nov and merged ~3 days later, but xpi is from 31 Oct).

https://github.com/mozilla/contain-facebook/issues/886#issuecomment-1307406211

It will be a part of our next release!

It remains to wait patiently.

[robmadole]

This also is affecting fontawesome.com/search. We're putting a workaround in place to fix.

[ghost]

@krystian3w @robmadole thank you! :D

[abatkin]

In case anyone comes searching. Stumptown Coffee Roasters checkout page is broken until this is released.

[TimmiX88]

This still hasn't been fixed, i still see the content_script.css being loaded into websites and it's styling affecting the website. Especially the .is-hidden class makes quite a few websites unusable. Please fix/rollout asap.

Edit: i see in the commits that a fix has been committed on november 5th, which sort of 'scopes' the .is-hidden class. However, the plugin says i am on the latest version (2.3.9, released on november 3rd). So seems that the rollout has stopped?

[TimmiX88]

This still hasn't rolled out. @maxxcrawford can you (or anyone at the team) please release this asap? Getting complains from clients that websites aren't working in Firefox and we shouldn't need to make changes to our websites if you just roll out the fix that has been commited months ago.

[JenniferKiesel]

I also experience this behaviour on the online banking website of "Sparkasse".

[krystian3w]

Someone has some issues more important than spoiling hundreds of pages.

[BradyThe]

That certainly explains the issue I had with a particular website.

For now I am using Stylus in combination with this code to dirty-fix this problem:

.is-hidden {
    display: inherit !important;
}

#fbc-email.is-hidden, #fbc-login.is-hidden {
    display: none;
}

[krystian3w]

Possible remove these dirty hacks if we try update to 2.3.10 or 2.3.11 from July 2023.

https://addons.mozilla.org/addon/facebook-container/versions/