mozilla / contain-facebook

Facebook Container isolates your Facebook activity from the rest of your web activity in order to prevent Facebook from tracking you outside of the Facebook website via third party cookies.
Mozilla Public License 2.0
985 stars 177 forks source link

Site search on TheAtlantic.com breaks when Facebook Container is active #903

Open oneofthedamons opened 1 year ago

oneofthedamons commented 1 year ago

Actual behavior

Pressing the search magnifying glass icon adjacent to the hamburger menu at the top-left of TheAtlantic.com/world does not activate the search function. The Popular and Latest links immediately to the right disappear, but the search box is not activated.

Expected behavior

The search function is activated when the Facebook Container extension is disabled. revealing a "Search The Atlantic…" search box (replacing the Popular and Latest links) which accepts user input.

Steps to reproduce

  1. Enable Facebook Container extension
  2. Go to TheAtlantic.com/world
  3. Press the search magnifying glass icon adjacent to the hamburger menu at the top-left of screen
  4. Confirm the Popular and Latest links disappear, but no search box is activated and no input is accepted
  5. Disabled the Facebook Container extension
  6. Reload the page
  7. Press the search control
  8. Confirm a search box is activated enabling user input

Notes

Not sure if this is a Facebook Container issue or a site coding issue. Please let me know if it is the latter, and I will report to the The Atlantic instead.

krystian3w commented 1 year ago

I see page still using .is-hidden, so generates known breakage:

921 #911 #898 #886 => #898

In practice, this is a bug of an outdated version of the add-on - based on merged PR with fix, so as the site does not have hundreds of reports that something does not work for it, it should not rewrite the logic of its code.