mozilla / crlite

WebPKI-level Certificate Revocation via Multi-Level Bloom Filter Cascade
http://www.cs.umd.edu/~dml/papers/crlite_oakland17.pdf
Mozilla Public License 2.0
70 stars 8 forks source link

moz_kinto_publisher: avoid overriding PublishedRunDB functions in MockRunDB tests #308

Closed jschanck closed 1 month ago

jschanck commented 2 months ago

The MockRunDB class in test_publisher.py was overriding PublishedRunDB's get_run_timestamps(), is_run_valid(), and is_run_ready() methods, because those methods usually make network requests to google cloud storage. This has caused us to miss bugs in local testing that end up taking down our stage instance (like the typo in main.py that this PR fixes). The strategy here is to instead define a "bucket" that uses the local file system instead of GCS.